Fix MDI child windows not appearing and menu corruption for Win16 apps#33
Merged
Fix MDI child windows not appearing and menu corruption for Win16 apps#33
Conversation
- message.ts: Sign-extend 16-bit MDICREATESTRUCT coordinates (same as MoveWindow/SetWindowPos) Clamp negative positions to 0 and oversized children to fill MDICLIENT area WINFILE passed y=-1026 (0xFBFE) which was stored as 64510 unsigned → off-screen - EmulatorView.tsx: Use callWndProc16 for NE apps in handleMenuOpen (was using Win32 callWndProc) Opening a menu on a Win16 app corrupted CPU state, breaking New Window and Exit - window.ts: Minor whitespace cleanup in SetWindowPos Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
y=-1026 (0xFBFE) were stored as 64510, placing the window off-screen. Now sign-extends coordinates and clamps to
MDICLIENT area.
executables like WINFILE.EXE. This corrupted the stack and EIP, making Window > New Window and File > Exit
unresponsive. Now uses callWndProc16() for NE apps.
Test plan